----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14450/#review26623 -----------------------------------------------------------
src/ios/CDVAccelerometer.m <https://reviews.apache.org/r/14450/#comment51867> I would avoid the strong reference to self here. See: http://teohm.github.io/blog/2012/09/03/breaking-arc-retain-cycle-in-objective-c-blocks/ Make a weak copy, and refer to it in the block. - Shazron Abdullah On Oct. 2, 2013, 7:48 p.m., James Jong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14450/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 7:48 p.m.) > > > Review request for cordova and Shazron Abdullah. > > > Bugs: CB-4825 > https://issues.apache.org/jira/browse/CB-4825 > > > Repository: cordova-plugin-device-motion > > > Description > ------- > > Move to using CoreMotion framework for iOS accelerometer in place of > deprecated UIAccelerometer. > > > Diffs > ----- > > src/ios/CDVAccelerometer.h 923d0c8 > src/ios/CDVAccelerometer.m 33093d0 > > Diff: https://reviews.apache.org/r/14450/diff/ > > > Testing > ------- > > Tested with 3.1 core. > > > Thanks, > > James Jong > >
