Nice work Shaz! Like the JS API so that they can be enabled / disabled at runtime.
Gotta upload that to the registry! plugman adduser shazron && plugman publish plugins/keyboard On Thu, Oct 3, 2013 at 12:02 AM, Shazron <shaz...@gmail.com> wrote: > Should be in. Try: > plugman install --platform ios --plugin > > https://git-wip-us.apache.org/repos/asf/cordova-labs.git#plugins:keyboard--project > /path/to/your/project/here > > > On Thu, Sep 26, 2013 at 10:25 PM, Shazron <shaz...@gmail.com> wrote: > > > Alright I'll add it to the > > https://github.com/apache/cordova-labs/tree/plugins branch > > > > > > On Thu, Sep 26, 2013 at 7:30 PM, Brian LeRoux <b...@brian.io> wrote: > > > >> +1 > >> On Sep 26, 2013 11:04 PM, "Michal Mocny" <mmo...@chromium.org> wrote: > >> > >> > You mean put it within cordova-labs/plugins? I agree it should start > >> life > >> > there. I don't think plugins should live in the platform repos, even > if > >> > they are currently platform specific. > >> > > >> > > >> > On Thu, Sep 26, 2013 at 4:11 PM, Andrew Grieve <agri...@chromium.org> > >> > wrote: > >> > > >> > > Makes sense to me if taking it out is feasible code-wise. Would > >> encourage > >> > > people to fork / fiddle with it themselves as well I think. > >> > > > >> > > Now that we have a registry, we don't need to create new repos for > >> them > >> > > (yay!). Maybe just put the plugins within cordova-ios/plugins? > >> > > > >> > > I think we'll need to wait until after 3.1 to rip it out. > >> > > > >> > > > >> > > On Wed, Sep 25, 2013 at 2:22 AM, James Jong <wjamesj...@gmail.com> > >> > wrote: > >> > > > >> > > > +1 Separating this from the core into a plugin is a good idea. > >> > > > > >> > > > Not sure that this fits into any existing plugin though. > >> > > > > >> > > > -James Jong > >> > > > > >> > > > On Sep 24, 2013, at 2:37 PM, Shazron <shaz...@gmail.com> wrote: > >> > > > > >> > > > > Issue: https://issues.apache.org/jira/browse/CB-3020 > >> > > > > > >> > > > > I've got it mostly working but I'm thinking this really should > >> move > >> > to > >> > > a > >> > > > > plugin, perhaps reside in an existing one? > >> > > > > > >> > > > > The things we are doing with hiding the keyboard accessory bar > and > >> > > > > shrinking the view etc are hackish and might break with any iOS > >> > update, > >> > > > and > >> > > > > imo fixes should not be tied to a core release. > >> > > > > > >> > > > > My proposal is to move the code for the two keyboard preferences > >> to a > >> > > > > plugin. > >> > > > > >> > > > > >> > > > >> > > >> > > > > >
