----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14495/#review26702 -----------------------------------------------------------
We leverage pre-creating a cordova directory in order to pre-create a .cordova/config.json. I haven't confirmed, but this seem unlikely to work with this patch. Phonegap-cli also uses this trick. Likely this patch can land once we can add the ability to set the default config file contents (such as www dir). - Michal Mocny On Oct. 4, 2013, 9:18 p.m., Mark Koudritsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14495/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 9:18 p.m.) > > > Review request for cordova. > > > Bugs: CB-4748 > https://issues.apache.org/jira/browse/CB-4748 > > > Repository: cordova-cli > > > Description > ------- > > CB-4748 Fail quickly if dir passed to cordova create is not empty. > > > Diffs > ----- > > src/create.js 4b2b9506c16ab5adc04f88f3c8d53766266df5c6 > > Diff: https://reviews.apache.org/r/14495/diff/ > > > Testing > ------- > > ran twice: > cordova create . > and > cordova create some_dir > > > Thanks, > > Mark Koudritsky > >
