It would be nice to have such hooks, but it only works well if everyone is running them. If some people are not, and they break the tests, now it's complaining at you when you try to commit. Also for people like me who commit every other save and then squash a dozen commits into one or two, it's very likely that some of the early ones will have broken tests. I guess a pre-push hook is a little better, but it still has the first problem.
I support CI and nag emails much more strongly. We already have this internally at Google; we added Plugman and CLI to our Buildbot CI last week. We're working on getting that publicly visible. Buildbot supports distributed testing, so we'll integrate results from Adobe's Device Wall eventually. In the short term, we're getting nag emails when the tests are failing, and we'll be passing along the message to the author of the broken change. Braden (Does anyone else picture The Monolith every time someone mentions the device wall?) On Tue, Oct 22, 2013 at 3:24 PM, Andrew Grieve <[email protected]> wrote: > I <3 hooks, but they are super hard to enforce with git since people need > to enable the manually. Although, maybe we could add that to coho's clone > command? > > cordova-ios already has some hooks, and I think they've worked well. > > > On Tue, Oct 22, 2013 at 3:06 PM, Carlos Santana <[email protected] > >wrote: > > > Thanks Steven. > > Wiki now contains the tips for testing cli > > > > https://wiki.apache.org/cordova/RunningTests > > > > What's the community opinion on "git pre-commit hooks" [1]? (we can start > > by implementing "npm test") > > > > Also integrating with travisci[2] should be a piece of cake just with the > > tests that we have today. > > > > > > [1]: http://git-scm.com/book/en/Customizing-Git-Git-Hooks > > [2]: > http://about.travis-ci.org/docs/user/languages/javascript-with-nodejs > > > > > > --Carlos > > > > > > On Tue, Oct 22, 2013 at 1:35 PM, Steven Gill <[email protected]> > > wrote: > > > > > Yeah good tips Carlos! I figured those tips out by spending time with > the > > > tests but I think it would be beneficial to write those down for people > > who > > > are looking to get started with our tests. Maybe on the wiki somewhere? > > > > > > -Steve > > > > > > > > > On Tue, Oct 22, 2013 at 9:37 AM, Michal Mocny <[email protected]> > > wrote: > > > > > > > Sounds good, thanks for those tips! > > > > > > > > > > > > On Tue, Oct 22, 2013 at 11:15 AM, Carlos Santana < > [email protected] > > > > >wrote: > > > > > > > > > I already checked and nothing breaks, and then I asked if it was OK > > to > > > > > update. > > > > > > > > > > That was my original question. > > > > > > > > > > I will update next time I'm working on test cases. > > > > > > > > > > Also useful tips when testing cordova-cli: > > > > > *1. Use "npm test" this calls > package.json "scripts": { "test": > > > > > "jasmine-node --color spec"}* > > > > > Remember when using npm "node_modules/bin" is in the $PATH > > > > > > > > > > *2. If something breaks "red F", then run verbose. > > > > > "./node_modules/jasmine-node/bin/jasmine-node spec --verbose"* > > > > > very useful to pin point spec.js that has the failing test, then do > > > step > > > > 3 > > > > > > > > > > *3. To run a single spec.js use > > > > > "./node_modules/jasmine-node/bin/jasmine-node spec/run.spec.js > > > > --verbose"* > > > > > > > > > > *4. Don't run global "jasmine-node", it might be a different > version > > > than > > > > > the one in cordoval-cli/plugman package.json* > > > > > At least I had a weird problem with my jasmine-node global install > & > > > nvm > > > > > I'm using nvm for node (ability to test different versions of node) > > > > > "jasmine-node --version" return 1.10.2, but "`which jasmine-node` > > > > > --version" return 1.11.0 > > > > > > > > > > > > > > > --Carlos > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Oct 22, 2013 at 10:48 AM, Michal Mocny < > [email protected]> > > > > > wrote: > > > > > > > > > > > I agree with updating in small steps. So, don't back off on > this, > > > just > > > > > > check if anything breaks, then do it! > > > > > > > > > > > > -Michal > > > > > > > > > > > > > > > > > > On Tue, Oct 22, 2013 at 10:28 AM, Carlos Santana < > > > [email protected] > > > > > > >wrote: > > > > > > > > > > > > > Michal, > > > > > > > Just to push to latest version. > > > > > > > > > > > > > > In my opinion is good to update dependencies in small steps, vs > > > going > > > > > > with > > > > > > > an old dependency for a long time and then doing major jump. > > > > > > > (What's the cordova community opinion? regards on updating npm > > > > > > dependencies > > > > > > > for cli/plugman) > > > > > > > > > > > > > > jasmine-node 1.11.1 support jasmine 1.3.11 (latest GA) > > > > > > > > > > > > > > From comparing releases/tags history on both jasmine and > > > > jasmine-node, > > > > > it > > > > > > > looks like jasmine-node picks up latest jasmine version pretty > > > > quickly. > > > > > > > > > > > > > > It's a minor thing anyway, I will leave it at 1.8.x then. > > > > > > > > > > > > > > --Carlos > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Oct 22, 2013 at 9:25 AM, Michal Mocny < > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > > > > > > > I have no objection, but am curious what the motivation for > > > upgrade > > > > > is? > > > > > > > > Just pushing to latest version, or is there some feature you > > > want > > > > (I > > > > > > ask > > > > > > > > because I'm evaluating jasmine-2.x and I'm curious about the > > > > > direction > > > > > > > > jasmine-node seems to be going). > > > > > > > > > > > > > > > > -Michal > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Oct 21, 2013 at 10:35 PM, Carlos Santana < > > > > > [email protected] > > > > > > > > >wrote: > > > > > > > > > > > > > > > > > I notice that there is a new version of jasmine-node 1.11.0 > > [1] > > > > > > > > > > > > > > > > > > I tested with 1.11.0 today and didn't find problems at the > > > > surface. > > > > > > > > > > > > > > > > > > It is OK to update the dependency to use the new version? > > > > > > > > > > > > > > > > > > [1] https://npmjs.org/package/jasmine-node > > > > > > > > > > > > > > > > > > -- > > > > > > > > > Carlos Santana > > > > > > > > > <[email protected]> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Carlos Santana > > > > > > > <[email protected]> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Carlos Santana > > > > > <[email protected]> > > > > > > > > > > > > > > > > > > > > -- > > Carlos Santana > > <[email protected]> > > >
