----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15046/ -----------------------------------------------------------
(Updated Nov. 7, 2013, 4:48 p.m.) Review request for cordova. Changes ------- Fixed conflicts in tests with this commit https://github.com/apache/cordova-cli/commit/5c9d4ee7773ebf9c3897423425c4906ca0a5db42 Bugs: CB-5063 https://issues.apache.org/jira/browse/CB-5063 Repository: cordova-cli Description ------- Currently all platform parsers (src/metadata/*_parser.js) copy cordova.js from util.libDirectory for each run of prepare. This results in errors when changing machines since the ~/.cordova/lib directory is not populated. With this change all the parsers construct the project www dir by first copying contents of a new dir named <project_root>/platforms/<platfrom>/platform_www (which contains cordova.js) and then the www dir from the app. Until individual platform create scripts will be updated to create the platform_www dir, prepare.js checks if the platform_www exists and if not, creates it using cordova.js from ~/.cordova/lib. Even after the platform create scripts are updated the check will be required for projects that were created using older version and don't yet have a platform_www dir. Diffs (updated) ----- spec/metadata/android_parser.spec.js 4afb52d spec/metadata/blackberry_parser.spec.js 3353eb1 spec/metadata/ios_parser.spec.js 17206c6 spec/metadata/windows8_parser.spec.js 5639317 spec/metadata/wp7_parser.spec.js 6b69d09 spec/metadata/wp8_parser.spec.js 02372cc spec/prepare.spec.js 8012924 src/metadata/android_parser.js df446e1 src/metadata/blackberry10_parser.js d9f71f3 src/metadata/firefoxos_parser.js c3edd7b src/metadata/ios_parser.js 20e985c src/metadata/windows8_parser.js 68520fc src/metadata/wp7_parser.js b19dc32 src/metadata/wp8_parser.js 3bdef16 src/prepare.js 4ea22c5 Diff: https://reviews.apache.org/r/15046/diff/ Testing ------- npm test corodva platform add android corodva platform add ios corodva platform add balckberry10 cordova prepare verified platfrom_www dir exists and contains the right file. Did not test for win platforms. Thanks, Mark Koudritsky
