DAMNIT MAPES Windows and Ant. =/
On Tue, Dec 3, 2013 at 4:22 PM, Michal Mocny <[email protected]> wrote: > It came from: > > commit 1bd490098127543cf89b02735ea29757a11aab0c > Author: Benn Mapes <[email protected]> > Date: Mon Aug 12 17:07:23 2013 -0700 > > > I haven't dug deep into that patch, but seems he was replacing windows' > create batch files with node scripts, and perhaps a made a few > windows-centric decisions for the platform as a whole. > > > On Tue, Dec 3, 2013 at 12:09 AM, Brian LeRoux <[email protected]> wrote: > > > That's my q too > > On Dec 3, 2013 3:51 PM, "Lorin Beer" <[email protected]> wrote: > > > > > was the only impetus for using JAVA_HOME to check if java is installed? > > > > > > > > > On Mon, Dec 2, 2013 at 8:41 PM, Michal Mocny <[email protected]> > > wrote: > > > > > > > Mark was kind enough to fix this for us. We should mark the JIRA as > > > > resolved. (Actually he used your suggestion Brian, check to make > sure > > > you > > > > can run java -version, thats it ;) > > > > > > > > commit 2f66ec60db8749bc442095560d5713b7bb718527 > > > > Author: Mark Koudritsky <[email protected]> > > > > Date: Wed Nov 27 16:59:20 2013 -0500 > > > > > > > > > > > > > > > > On Mon, Dec 2, 2013 at 11:09 PM, Lorin Beer < > [email protected] > > > > >wrote: > > > > > > > > > Comment out the call to check_java, and the CLI can successfully > > > compile, > > > > > and install the app to device or emulator successfully. > > > > > > > > > > So for what functionality is JAVA_HOME necessary for? > > > > > > > > > > > > > > > > > > > > On Mon, Dec 2, 2013 at 6:33 PM, Brian LeRoux <[email protected]> wrote: > > > > > > > > > > > I'm trying to understand why we are doing this and how it got > > pushed > > > so > > > > > > this type of thing does not happen again. > > > > > > > > > > > > I have java. I can java -version it right now. > > > > > > > > > > > > Why are we checking for an environment variable called JAVA_HOME? > > > > > > > > > > > > > > > > > > On Tue, Dec 3, 2013 at 1:21 PM, Carlos Santana < > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > > > > > check_java() was never called properly from run() until > recently > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/cordova-android/commit/5ab11edad230980379282c5a6b83eec12f7b1c5b#diff-f477d7d5a4a7b8cc0bfe70b71a81920f > > > > > > > > > > > > > > for now I worked around on Mac by > > > > > > > export JAVA_HOME=$(/usr/libexec/java_home) > > > > > > > > > > > > > > :-( > > > > > > > > > > > > > > > > > > > > > On Mon, Dec 2, 2013 at 8:59 PM, Brian LeRoux <[email protected]> > wrote: > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/CB-5422 > > > > > > > > > > > > > > > > why?! > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Carlos Santana > > > > > > > <[email protected]> > > > > > > > > > > > > > > > > > > > > > > > > > > > >
