On Fri, Dec 6, 2013 at 2:15 PM, Sergey Grebnov (Akvelon) < [email protected]> wrote:
> Agree and like this idea. I don't think there are many other components > (if any) which use ArrayBuffer but must be tested well anyway since this > changes core. Ian do you want to complete this yourself or you are ok if I > handle this? > I'm totally okay with you doing it -- I don't have a real windows phone device to test it on; I'd be committing with my eyes closed and hoping for the best :) I think you're right that there aren't any other core plugins using the binary bridge, but that could change, and there are probably already third-party plugins using it. If we do this right, then other developers won't have to roll their own solution in each case, and it will be easier to port the third-party plugins to WP. Let me know if you need any support; I'll help if I can. Ian > > -Sergey > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of Ian > Clelland > Sent: Friday, December 6, 2013 7:37 PM > To: [email protected] > Subject: Windows Phone binary bridge > > As far as I can tell from reading its exec.js, WP8 does not have a binary > bridge of any kind. Non-string data get JSON-serialized for transfer. > > The recent patch for CB-5532 broke the File plugin by explicitly casting > ArrayBuffer data to Array type. Sergey's fixed it now, but the FileWriter > JS code still has special cases for Windows and WP8 platforms. > > Would it make sense to have this code moved into the WP8 exec bridge? Then > it could apply to any plugins which transfer binary data, and any improved > transport methods would automatically be used by all plugins, rather than > being a special case in each plugin. > > I don't know much about the Windows phone platform, so I could be > completely off-base about this, but if it works, I think it'll make the > implementation cleaner, and generally make Cordova better on the platform. > > Ian >
