-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16988/
-----------------------------------------------------------
(Updated Jan. 17, 2014, 7:11 p.m.)
Review request for cordova.
Changes
-------
Added caching in config-changes.process() where it calls add_plugin_changes()
Bugs: CB-5299
https://issues.apache.org/jira/browse/CB-5299
Repository: cordova-plugman
Description
-------
Same diff on github:
https://github.com/kamrik/cordova-plugman/compare/fast_prepare
Corresponding change in cordova-cli: https://reviews.apache.org/r/16991/
Parsing pbxproj is slow (~250ms on my machine). When running "cordova prepare"
it is done for each plugin that needs to add frameworks to the ios project.
This change is a quick and dirty fix to allow caching the parsed pbxproj object
so that it can be reused for multiple plugins during prepare. Non ios projects
are not affected.
Sample timings for "cordova prepare ios" on a test project with 3 relevant
plugins:
before: 1.623s
after: 0.981s
Diffs (updated)
-----
spec/util/config-changes.spec.js 795d825
src/util/config-changes.js 2009f7f
Diff: https://reviews.apache.org/r/16988/diff/
Testing
-------
npm test
cordova prepare
cordova build
cordova create ...
Thanks,
Mark Koudritsky
