----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17168/#review32663 -----------------------------------------------------------
Ship it! Ship It! - Andrew Grieve On Jan. 22, 2014, 2:31 a.m., Mark Koudritsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17168/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 2:31 a.m.) > > > Review request for cordova. > > > Bugs: CB-5782 > https://issues.apache.org/jira/browse/CB-5782 > > > Repository: cordova-cli > > > Description > ------- > > Other than the trivial changes that look like > new Error(...) -> new CordovaError(...) > there is also a change in util.js to throw the error instead of returning it > and associated changes in specs. > > > Diffs > ----- > > spec/build.spec.js 98b5ccc > spec/compile.spec.js 91228a9 > spec/emulate.spec.js 4809cc0 > spec/prepare.spec.js 0388ec8 > spec/run.spec.js 159ea00 > src/build.js 54eb7ec > src/compile.js 78c72ed > src/create.js 3de4e77 > src/emulate.js be248c5 > src/platform.js 1b7f179 > src/plugin.js 5ef98ce > src/prepare.js 2dd7d35 > src/run.js 198bd32 > src/util.js be843be > > Diff: https://reviews.apache.org/r/17168/diff/ > > > Testing > ------- > > npm test > cordova create / prepare / build > > > Thanks, > > Mark Koudritsky > >
