Does the squash keep original author info? I know the hashes change so they don't match up, but if we have the author and a reference to the PR in the commit, I think thats fine for me.
Alternative is to ask the contributor to do the squash, which we do try to do, but its usually the non-responsive contributors that submit the nasty PR in the first place (go figure). -Michal On Fri, Feb 28, 2014 at 5:14 PM, Joe Bowser <[email protected]> wrote: > Hey > > I saw the wiki was updated, and I'm not quite sure how I feel about this: > https://wiki.apache.org/cordova/ProcessingPullRequests > > # REPO_NAME example: "js" > # PULL_REQUEST_NUMBER example: "44" > curl > https://github.com/apache/cordova-REPO_NAME/pull/PULL_REQUEST_NUMBER.patch > | git am > git rebase origin/master -i > > First, I'd add git am --signoff so that it adds your git e-mail to it. > This just looks nice, but I'm not sure how I feel about doing the > commit squishing and pruning, since we want to have a nice audit trail > back to GitHub to see what we were doing. I know it makes it harder > to do release notes, but the one thing that I get super picky about is > who wrote what code, and it matching up. > > Am I just being all Apache about this, and we could be way more lax? > What are people's thoughts? > > Joe >
