I'm still unclear as to why it's a bad default.
On Mon, Mar 3, 2014 at 11:19 AM, Andrew Grieve <[email protected]> wrote: > How about: > 1. Make the default not setting it. > 2. Add a pref that will change it to media volume. > 3. Set that pref in mobile spec, and advertise it in Media's documentation. > > > On Mon, Mar 3, 2014 at 2:13 PM, Joe Bowser <[email protected]> wrote: > >> Default is the Phone Button for things that aren't games. Given the >> fact that we have an Audio API, I would like to see the default be the >> media volume. This is because I want to easily be able to adjust the >> volume before Mobile-Spec plays the test sound. Of course, this >> should be configurable. >> >> On Mon, Mar 3, 2014 at 11:03 AM, Andrew Grieve <[email protected]> >> wrote: >> > On Mon, Mar 3, 2014 at 11:15 AM, Joe Bowser <[email protected]> wrote: >> > >> >> On Mon, Mar 3, 2014 at 7:39 AM, Andrew Grieve <[email protected]> >> >> wrote: >> >> > Filed JIRAs for this but wanted to see if anyone thinks this isn't the >> >> way >> >> > to go: >> >> > >> >> > 1. https://issues.apache.org/jira/browse/CB-6153 >> >> > Don't automatically hook up the volume buttons to media volume >> >> >> >> That's a good default as opposed to hooking it up to alerts volume, or >> >> having it not work at all. >> >> >> > >> > From my experience as an Android user, most apps have the volume buttons >> > hooked up to the phone's volume, and only games / music apps adjust the >> > media volume. I haven't checked yet what the default is (e.g. if we don't >> > set it at all), but I suspect it would be the phone volume. >> > >> > >> > >> >> >> >> > >> >> > 2. https://issues.apache.org/jira/browse/CB-6154 >> >> > Remove "showkeyboard" and "hidekeyboard" events. >> >> >> >> Do these events actually work? I believe that they were broken in a >> >> past version of Android. It'd be good to delete >> >> LinearLayoutSoftKeyboardDetect if this didn't work, otherwise I think >> >> we should definitely keep these events since we can use it to attempt >> >> to fix a really annoying bug with the Keyboard and Full Screen apps. >> >> >>
