Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/44#discussion_r10442686
--- Diff: contacts/index.html ---
@@ -127,8 +39,8 @@
<span id="contacts_results"> </span>
</div>
<h2>Action</h2>
- <div class="btn large" onclick="getContacts();">Get phone's
contacts</div>
--- End diff --
I'm -1 on mixing commits.
You have code refactors (such as here) and bug fixes elsewhere, and
platform portability elsewhere.
Please split each of these into distinct commits.
It's very very very hard to review a change when it's doing lots of
unrelated things together.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
