Marc, was that change to the actual version of plugman, in plugman's package.json file? Or the declared dependency in cli's package.json?
On Fri, Apr 4, 2014 at 11:25 AM, Marc Weiner <[email protected]> wrote: > I was able to get npm install to work by changing the version of plugman > from 0.21.0 to 0.21.2. > > Marc > > > On Fri, Apr 4, 2014 at 11:19 AM, Ian Clelland <[email protected] > >wrote: > > > After some heated discussion here, we're pretty sure that that's the > > problem with the CI, and that it's not going to work if we release it > > as-is. :( > > > > The really awful thing is that it doesn't look like it's possible to use > > package.json and npm-shrinkwrap.json properly, and end up with a release > > candidate that works *now*, and also works when the packages are actually > > released to npm. > > > > (If npm-shrinkwrap.json properly points to v0.21.0, then it won't install > > until that gets released. If we release v0.21.0-rc1, and point shrinkwrap > > to that, then it won't download 0.21.0 when we release it. And if we > > release 0.21.0 on npm before the vote, and it gets voted down, then we > > start burning through version numbers until the vote passes) > > > > However, we do need to produce *something* that we can vote on, and I > think > > it needs to be the version that works after the packages are released, > even > > if it requires some hackery to test it before then. > > > > I think the best thing that we can do in the situation is this: > > * Make CLI's npm-shrinkwrap.json point to the version that doesn't > exist > > yet on npm -- {"version": "0.21.0", "from": "[email protected]"} > > * Make CLI's package.json depend on any version of plugman > ">=0.21.0-rc" > > * Sign and release that for a vote. > > * Everyone can download it, and just remove npm-shrinkwrap.json before > > running npm-install. That should install correctly, and we can test the > > tools. > > * Once it passes, we publish cli and plugman to npm with the correct > > version numbers, and it will install correctly for end users. > > > > > > > > > > On Fri, Apr 4, 2014 at 10:47 AM, Ian Clelland <[email protected] > > >wrote: > > > > > There may be a packaging error with cli -- the npm-shrinkwrap.json file > > > specifies a relative file path, that I think will stop "npm install" > from > > > working on cli: > > > > > > ... > > > "plugman": { > > > "version": "0.21.0", > > > "from": "../cordova-plugman", > > > ... > > > > > > (It doesn't stop it from working completely; it actually did work for > me > > > the first time, but that's just because I actually *had* a > > cordova-plugman > > > directory right beside my cordova-cli directory, and I had specifically > > > checked out the 0.21.0 tag. It has been failing the CI tests, though, > and > > > we haven't been able to get it to install correctly when checked out > > into a > > > new directory) > > > > > > I'm -1 until we can fix that, sorry. :( > > > > > > (Or until we determine that it's not actually the problem) > > > > > > > > > > > > On Fri, Apr 4, 2014 at 4:05 AM, Sebastien Blanc <[email protected] > > >wrote: > > > > > >> +1 > > >> > > >> > > >> On Fri, Apr 4, 2014 at 10:00 AM, Steven Gill <[email protected]> > > >> wrote: > > >> > > >> > Please review and vote on the release of this cordova-cli, > > >> cordova-plugman > > >> > and cordova-ios release. > > >> > > > >> > [email protected], [email protected] and > > [email protected] > > >> > been published here: > > >> > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/ > > >> > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>* > > >> > > > >> > > > >> > The packages were published from their corresponding git tags: > > >> > cordova-cli: 3.4.1-0.1.0 (b769a304be) > > >> > cordova-plugman: 0.21.0 (b2f3a130d3) > > >> > cordova-ios: 3.4.1 (a96d2360fa) > > >> > > > >> > Upon a successful vote I will upload the cli & plugman archives to > > dist/ > > >> > and publish them to npm. Cordova-ios will be uploaded to > > >> dist/platforms. I > > >> > will then post the corresponding blog post. > > >> > > > >> > Voting will go on for a minimum of 24 hours. > > >> > > > >> > I vote +1. > > >> > > > >> > If people want individual vote threads for each item, let me know > and > > I > > >> > will create them instead of this thread. > > >> > > > >> > > > > > > > > >
