No, it's not a huge deal. I was only suggesting we avoid it if possible, otherwise update the README.
Our internal CI starting failing as soon as that commit was made as well. Anyone using this downstream will need to make changes. On Fri, Apr 4, 2014 at 1:45 PM, Steven Gill <[email protected]> wrote: > Sorry, didn't mean to hit send on that last message quite so quickly. > > We could add release branches but it would require us to change our release > process for them. > > Isn't master only broken until we release. If the process is completed > within 24hours, is having master broken a huge deal? Most people will use > npm to install cordova anyways. > > > > On Fri, Apr 4, 2014 at 10:43 AM, Steven Gill <[email protected]> > wrote: > > > We don't have release branches for CLI + Plugman. > > > > > > On Fri, Apr 4, 2014 at 10:40 AM, Bryan Higgins <[email protected] > >wrote: > > > >> SGTM > >> > >> > >> On Fri, Apr 4, 2014 at 1:38 PM, Ian Clelland <[email protected]> > >> wrote: > >> > >> > What about only adding the shrinkwrap file to git just before release, > >> on > >> > the release branch? Then only published releases on npm (and on > >> > dist.apache.org) will include that file, and the only people who have > >> to > >> > delete it manually are those people testing the release candidate. > >> Anyone > >> > getting master from git will not have that file. > >> > > >> > > >> > On Fri, Apr 4, 2014 at 1:25 PM, Bryan Higgins <[email protected] > >> > >wrote: > >> > > >> > > Right, but someone outside of this group stumbling upon the repo on > >> > GitHub > >> > > won't be able to use it unless they know to delete the shrinkwrap > >> file. > >> > I'd > >> > > rather the process be a bit more cumbersome for us and preserve the > >> > > integrity of repo. > >> > > > >> > > > >> > > On Fri, Apr 4, 2014 at 1:11 PM, David Kemp <[email protected]> > >> wrote: > >> > > > >> > > > If we make the proposed change to the CLI package.json (change the > >> > > plugman > >> > > > dependency to ">=0.21.0-rc"), > >> > > > then all that is required for testing is to delete the shrinkwrap > >> file. > >> > > > > >> > > > That means a little less hackery to test the package that is being > >> > voted > >> > > > on. > >> > > > > >> > > > We have currently made those changes on the fly in the CI to get > it > >> > > working > >> > > > again. > >> > > > > >> > > > > >> > > > > >> > > > On Fri, Apr 4, 2014 at 12:57 PM, Bryan Higgins < > >> [email protected] > >> > > > >wrote: > >> > > > > >> > > > > The other problem we face is the actual repo being unusable for > a > >> > > period > >> > > > of > >> > > > > time unless you know how to fiddle with package.json / > >> > > > npm-shrinkwrap.json. > >> > > > > > >> > > > > At the very least this should be pointed out on the README, but > >> even > >> > > that > >> > > > > doesn't seem friendly to potential contributors. > >> > > > > > >> > > > > I'm in favour of bumping the version number in CLI after the > vote > >> for > >> > > > cases > >> > > > > like this where we're releasing tools together. Those testing > the > >> CLI > >> > > for > >> > > > > release can bump up the plugman version locally. > >> > > > > > >> > > > > Otherwise we should vote on plugman first, then update CLI and > >> vote > >> > on > >> > > > > that... > >> > > > > > >> > > > > > >> > > > > On Fri, Apr 4, 2014 at 12:33 PM, Parashuram Narasimhan (MS OPEN > >> > TECH) < > >> > > > > [email protected]> wrote: > >> > > > > > >> > > > > > Can we also include the Windows Phone and Windows Platform, > >> > > > specifically > >> > > > > > for the following bugs/pull requests > >> > > > > > > >> > > > > > 1. Windows 8 - > >> > > https://github.com/apache/cordova-windows/pull/20- > >> > > > > > This is more of a regression in case VS2013 is installed. With > >> the > >> > > > build > >> > > > > > announcement yesterday, this could be higher priority. Note > that > >> > this > >> > > > is > >> > > > > > not yet merged in. > >> > > > > > 2. Windows Phone 8 - > >> > > > https://github.com/apache/cordova-wp8/pull/28- > >> > > > > > This could affect the users using the emulator. > >> > > > > > > >> > > > > > -----Original Message----- > >> > > > > > From: Axel Nennker [mailto:[email protected]] > >> > > > > > Sent: Friday, April 4, 2014 9:21 AM > >> > > > > > To: dev > >> > > > > > Subject: Re: [VOTE] [email protected], > >> > > [email protected] > >> > > > > > [email protected] > >> > > > > > > >> > > > > > Is there a chance to get the cb-2606 patch for launcer icon > >> support > >> > > > into > >> > > > > a > >> > > > > > release some time no too far? > >> > > > > > > >> > > > > > Axel > >> > > > > > Am 04.04.2014 10:01 schrieb "Steven Gill" < > >> [email protected] > >> > >: > >> > > > > > > >> > > > > > > Please review and vote on the release of this cordova-cli, > >> > > > > > > cordova-plugman and cordova-ios release. > >> > > > > > > > >> > > > > > > [email protected], [email protected] and > >> > > > [email protected] > >> > > > > > > have been published here: > >> > > > > > > *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/ > >> > > > > > > <https://dist.apache.org/repos/dist/dev/cordova/CB-6245/>* > >> > > > > > > > >> > > > > > > > >> > > > > > > The packages were published from their corresponding git > tags: > >> > > > > > > cordova-cli: 3.4.1-0.1.0 (b769a304be) > >> > > > > > > cordova-plugman: 0.21.0 (b2f3a130d3) > >> > > > > > > cordova-ios: 3.4.1 (a96d2360fa) > >> > > > > > > > >> > > > > > > Upon a successful vote I will upload the cli & plugman > >> archives > >> > to > >> > > > > > > dist/ and publish them to npm. Cordova-ios will be uploaded > to > >> > > > > > > dist/platforms. I will then post the corresponding blog > post. > >> > > > > > > > >> > > > > > > Voting will go on for a minimum of 24 hours. > >> > > > > > > > >> > > > > > > I vote +1. > >> > > > > > > > >> > > > > > > If people want individual vote threads for each item, let me > >> know > >> > > and > >> > > > > > > I will create them instead of this thread. > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > > > >
