Sounds good.
On Fri, Apr 4, 2014 at 12:36 PM, purplecabbage <[email protected]>wrote: > I am a +1 > I would like to see ALL tests in a 'spec' or 'tests' folder though, as it > is not obvious what 'e2e' is. > > Sent from my iPhone > > > On Apr 4, 2014, at 12:27 PM, Josh Soref <[email protected]> wrote: > > > > Mark wrote: > >> Back in november we had a > >> discussion< > https://www.mail-archive.com/[email protected]/msg11708.ht > >> ml>about > >> new tests that use less mocks, especially for fs. The idea was well > >> received and for some time now there are 4 such tests in > cordova-cli/e2e/ > >> e2e/create.spec.js > >> e2e/hooker.spec.js > >> e2e/platform.spec.js > >> e2e/plugin.spec.js > >> > >> They seem to be stable and well behaved but in order to achieve their > main > >> goal - reduction of test maintenance cost - we need to remove the > >> corresponding 4 tests in spec/ > >> I think it¹s time to delete them. > >> > >> Comments? > > > > > https://github.com/apache/cordova-cli/blob/eee9b273b7b58a6a2abc1dc306129739 > > be95bb2c/spec/platform.spec.js#L306 > > > > > > isn¹t covered by the new e2e stuff. > > > > If you¹re going to do this (and I¹m +1 on the idea), please either > itemize > > what¹s missing and file bugs to restore them, or merge over the missing > > bits. > > >
