Looks good, but I think we should also import hooks/. Also, I think we could attempt a bit of a refactor of the implementation, but I'm happy to leave that for after we break out cordova-lib.
On Tue, Apr 22, 2014 at 11:07 PM, Mark Koudritsky <[email protected]> wrote: > Fixed it so that cordova doesn't complain about missing "platforms" dir > when on platform ls or add. > So if you do > rm -rf platfroms > and then > cordova platform add android, ios, ... > you get a working project again. > > cordova plugins ls/add > is already fine with missing plugins dir. > cordova prepare fails with no plugins dir, and it should until we teach it > to restore plugins from config.xml. > > Here is a change for --link-to / --copy-from to also link/copy "merges" and > config.xml > https://github.com/apache/cordova-cli/pull/169 > does it look ok? > > > > > On Tue, Apr 22, 2014 at 12:33 PM, Michal Mocny <[email protected]> > wrote: > > > I was brainstorming about this a week ago. Specifically, there is also > an > > issue to support "git clone" as the source for an application template, > and > > that one gets tricky with the current way we link/copy. > > > > An app consists of (and we should import all of) the following: > > - www > > - config.xml > > - hooks > > - merges > > > > So, talking with Mark about what the CLI does during "cordova create" > (not > > much), the only thing stopping us from supporting a workflow using actual > > cp -r, ln -s, or git clone is that there must exist a platforms/ and > > plugins/ folder. Thats it. > > > > After we fix that problem, the workflow would be: > > - Create a new cordova workspace with, Option 1: cordova create. Option > 2: > > cp -r/ln -s/git clone an existing/boilerplate project > > - cordova prepare (will auto-create platforms/ and plugins/ and > > auto-install the necessary versions after Gorken finishes his work) > > > > I think that is a better workflow than passing arguments to cordova > create > > to do the imports by copy/link/clone/etc. > > > > -Michal > > > > > > > > > > On Tue, Apr 22, 2014 at 12:10 PM, Brian LeRoux <[email protected]> wrote: > > > > > working only for www makes sense to me. if I'm creating a wholesale > copy > > > why not just cp -r? changing the namespace? > > > > > > > > > On Tue, Apr 22, 2014 at 8:53 AM, Andrew Grieve <[email protected]> > > > wrote: > > > > > > > There's an outstanding bug that --copy-from and --link-to work only > for > > > > www/. https://issues.apache.org/jira/browse/CB-5833. Would be great > if > > > > anyone wanted to take it on :) > > > > > > > > > > > > On Tue, Apr 22, 2014 at 9:38 AM, Wargo, John <[email protected]> > > wrote: > > > > > > > > > I was relying upon the docs. The CLI help is pretty unreadable in a > > > > > terminal window on Windows as it's written for a 120 character wide > > > > screen > > > > > for some reason and Windows terminal by default is 80 characters > > wide. > > > I > > > > > guess we need to get the docs updated to reflect these parameters. > > I'll > > > > > submit a ticket and perhaps fix this. > > > > > > > > > > What about hooks though? It seems that the copyfrom option is for > the > > > www > > > > > folder contents, but what about merges and hooks? Shouldn't a > > > 'complete' > > > > > project template include both as well? It seems to me that the > > copyto > > > > > option should copy to the root project level which would then allow > > > > > developers to include stuff in hooks and merges as well as www when > > > > copying > > > > > over a project template. > > > > > > > > > > What do you think? > > > > > > > > > > John M. Wargo > > > > > SCN Blog: http://scn.sap.com/blogs/johnwargo > > > > > Twitter: @johnwargo > > > > > > > > > > -----Original Message----- > > > > > From: Shazron [mailto:[email protected]] > > > > > Sent: Monday, April 21, 2014 1:29 PM > > > > > To: [email protected] > > > > > Subject: Re: Hooks > > > > > > > > > > In the help for cordova create in 3.4, there is the --copy-from and > > > > > --link-to options. > > > > > > > > > > > > > > > > > > > > On Mon, Apr 21, 2014 at 10:22 AM, John Wargo <[email protected]> > > > wrote: > > > > > > > > > > > Regarding hooks, is there an easy way to deploy them to your > > project? > > > > For > > > > > > example, with the ability to specify a project template to use > with > > > the > > > > > CLI > > > > > > create command, can that include hooks? > > > > > > > > > > > > I thought the template option was added to the CLI, but the 3.4 > CLI > > > > docs > > > > > > don't mention it: > > > > > http://cordova.apache.org/docs/en/3.4.0/guide_cli_index. > > > > > > md.html#The%20Command-Line%20Interface. Is it in there? > > > > > > > > > > > > > > > > > > > > >
