Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/136#discussion_r12410577
--- Diff: src/metadata/ubuntu_parser.js ---
@@ -102,20 +102,27 @@ module.exports.prototype = {
hooks: { cordova: { desktop: "cordova.desktop",
apparmor: "apparmor.json" } },
framework: "ubuntu-sdk-13.10",
- maintainer: sanitize(this.config.author()),
+ maintainer: sanitize(this.config.author()) + "
<" + this.config.doc.find('author').attrib.email + ">",
architecture: arch,
description: sanitize(this.config.description())
};
- fs.writeFileSync(path.join(this.path, 'manifest.json'),
JSON.stringify(manifest));
var name = this.config.name().replace(/\n/g, ' '); //FIXME:
escaping
var content = "[Desktop Entry]\nName=" + name +
"\nExec=./cordova-ubuntu
www/\nIcon=qmlscene\nTerminal=false\nType=Application\nX-Ubuntu-Touch=true";
+ var name = sanitize(this.config.name()); //FIXME: escaping
--- End diff --
You have name and content defined right above this line as well. Error?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
