Thanks Steve

I fixed coho to update the version for firefoxos in the future

https://github.com/apache/cordova-coho/pull/24




On Tue, May 20, 2014 at 1:05 PM, Steven Gill <[email protected]> wrote:

> This thread has failed, just sent out a new vote thread. The zips are being
> uploaded for ffos to dist/dev right now
>
>
> On Tue, May 20, 2014 at 8:06 AM, Steven Gill <[email protected]>
> wrote:
>
> > Not sure. I will have to investigate. I will retag and start a new vote
> > thread for it today.
> >  On May 20, 2014 7:35 AM, "Axel Nennker" <[email protected]> wrote:
> >
> >> How did this happen anyway?
> >> The comment in the file says that coho would update the version.
> >> Why didn't it?
> >>  Am 20.05.2014 09:25 schrieb "Piotr Zalewa" <[email protected]>:
> >>
> >> > +1
> >> >
> >> > I've fixed the issue, please "revote"
> >> >
> >> >
> >> >
> >> > W dniu 20/05/2014 03:50, Carlos Santana pisze:
> >> >
> >> >> -1
> >> >> Only problem is that version is wrong it states "3.4.0-dev" when
> doing
> >> >> "cordova platform ls"
> >> >>
> >> >> Don't feel very strong on -1, but is kind of problematic when
> reporting
> >> >> wrong version number
> >> >>
> >> >> I opened https://issues.apache.org/jira/browse/CB-6718
> >> >>
> >> >> https://github.com/apache/cordova-firefoxos/blob/master/
> >> >> bin/templates/project/cordova/version#L23
> >> >>
> >> >> $cordova platform ls
> >> >>
> >> >> Installed platforms: firefoxos *3.4.0-dev*
> >> >>
> >> >> Available platforms: amazon-fireos, android, blackberry10, ios
> >> >>
> >> >>
> >> >> On Mon, May 19, 2014 at 4:26 PM, Rodrigo Silveira <
> >> [email protected]
> >> >> >wrote:
> >> >>
> >> >>  +1
> >> >>> * Tested using npm install @rc
> >> >>>
> >> >>> ----- Original Message -----
> >> >>> From: "Steven Gill" <[email protected]>
> >> >>> To: [email protected]
> >> >>> Sent: Thursday, May 15, 2014 11:49:01 AM
> >> >>> Subject: [VOTE] 3.5.0 cordova-firefoxos Release (attempt 2)
> >> >>>
> >> >>> Please review and vote on this 3.5.0 cordova-firefoxos Release.
> >> >>>
> >> >>> Release issue: https://issues.apache.org/jira/browse/CB-6586
> >> >>>
> >> >>> Repos ready to be released have been published to dist/dev:
> >> >>> https://dist.apache.org/repos/dist/dev/cordova/CB-6586/final
> >> >>>
> >> >>> The package was published from the corresponding git tag:
> >> >>> cordova-firefoxos: 3.5.0 (27a505695a)
> >> >>>
> >> >>> Upon a successful vote I will upload the archives to dist/, publish
> >> them
> >> >>> to
> >> >>> NPM, and post the corresponding blog post.
> >> >>>
> >> >>> Voting guidelines:
> >> >>> https://github.com/apache/cordova-coho/blob/master/docs/
> >> >>> release-voting.md
> >> >>>
> >> >>> Voting will go on for a minimum of 48 hours.
> >> >>>
> >> >>> I vote +1:
> >> >>> * Verified archive
> >> >>> * Ensured continuous build was green when repos were tagged
> >> >>>
> >> >>>
> >> >>
> >> >>
> >> >>
> >> > --
> >> > Piotr Zalewa
> >> > Mozilla
> >> >
> >>
> >
>



-- 
Carlos Santana
<[email protected]>

Reply via email to