The vote has now closed. The results are: Positive Binding Votes: 4
Steve Gill Ian Clelland Shazron Abdhullah James Jong Negative Binding Votes: 0 The vote has passed. On Tue, May 20, 2014 at 8:54 AM, Shazron <[email protected]> wrote: > It is already using the latest battery-status-plugin code, I verified - > still fails. See https://issues.apache.org/jira/browse/CB-6721 on why its > failing. > > > On Tue, May 20, 2014 at 8:24 AM, purplecabbage <[email protected] > >wrote: > > > And it's just a new test. There were NO tests before. Update/repub the > > battery plugin and the test will pass. > > > > Sent from my iPhone > > > > > On May 20, 2014, at 8:12 AM, Ian Clelland <[email protected]> > > wrote: > > > > > > Yep. It's just in the battery-status plugin. > > > > > > > > > On Tue, May 20, 2014 at 11:08 AM, Steven Gill <[email protected] > > >wrote: > > > > > >> Is this a plugin issue or platform issue? Looks like a plugin one. > > >> Filed: https://issues.apache.org/jira/browse/CB-6721 > > >> > > >> Battery (navigator.battery) battery.spec.4 should fire batterycritical > > >> events. > > >> timeout: timed out after 100 msec waiting for batterycritical onEvent > > was > > >> not called when level goes from 19->5 > > >> > > >> > > >>> On Tue, May 20, 2014 at 2:01 AM, Shazron <[email protected]> wrote: > > >>> > > >>> +1 verified archive using coho. > > >>> Verified tag sha, and zip contents identical to repo contents at that > > >> tag. > > >>> When I initially tagged iOS, all tests were passing in mob-spec, but > > now > > >>> the battery-status plugin is failing 1 test (battery.spec.4) > > >>> > > >>> > > >>> On Thu, May 15, 2014 at 10:36 AM, Ian Clelland < > [email protected] > > >>> wrote: > > >>> > > >>>> +1: Verified archive, confirmed match to [email protected]. Ran tests on > iOS > > >>>> 7.0.6, 7.1.1. (Enough tests to ensure that the platform is > > functioning. > > >> CI > > >>>> is red because of battery-status plugin.) > > >>>> > > >>>> > > >>>> On Wed, May 14, 2014 at 4:12 PM, Steven Gill < > [email protected]> > > >>>> wrote: > > >>>> > > >>>>> Please review and vote on this 3.5.0 iOS Release. > > >>>>> > > >>>>> Release issue: https://issues.apache.org/jira/browse/CB-6586 > > >>>>> > > >>>>> Repos ready to be released have been published to dist/dev: > > >>>>> https://dist.apache.org/repos/dist/dev/cordova/CB-6586/final > > >>>>> > > >>>>> The package was published from the corresponding git tag: > > >>>>> cordova-ios: 3.5.0 (643886ba8b) > > >>>>> > > >>>>> Upon a successful vote I will upload the archives to dist/, publish > > >>>> them to > > >>>>> NPM, and post the corresponding blog post. > > >>>>> > > >>>>> Voting guidelines: > > >> > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > >>>>> > > >>>>> Voting will go on for a minimum of 48 hours. > > >>>>> > > >>>>> I vote +1: > > >>>>> * Verified archive > > >>>>> * Ensured continuous build was green when repos were tagged > > >> > > >
