I like the reflection idea since that will let us avoid branching & make the plugins work with both 3.x and 4.x. Others will hit the same problem, but likely others will want a way to target both versions as the solution.
On Fri, Jun 6, 2014 at 10:51 AM, Ian Clelland <iclell...@chromium.org> wrote: > This has been bugging me for a bit now. We definitely need a branch for > development on the plugins. (FTR, there's a pluggable_webview branch on > file, file-transfer and media-capture already, with this particular fix. We > can rename that) > > We're going to have trouble releasing these plugins when we release > cordova-android 4.0.0 -- I don't think that the tools right now will > support having two installable versions of a plugin, distinguished only by > one of the <platform> version requirements. That's a deficiency that we > need to fix before 4.0. > > Alternately, we use reflection in our core plugins to see whether the > WebView class has these methods, and support both 3.x and 4.x with the same > code. That's a pretty ugly solution, though, and doesn't help anyone else > in the same situation. > > > On Fri, Jun 6, 2014 at 9:56 AM, Marcel Kinard <cmarc...@gmail.com> wrote: > > > That is my first thought as well. Perhaps name the plugin branch > something > > like “android-4.0”? > > > > On Jun 5, 2014, at 5:38 PM, Steven Gill <stevengil...@gmail.com> wrote: > > > > > 4.0 branch for the plugins? > > > > > > > > > On Thu, Jun 5, 2014 at 2:33 PM, Joe Bowser <bows...@gmail.com> wrote: > > > > > >> Hey > > >> > > >> So, since we're wanting to introduce new APIs, such as > > >> getPluginManager() and getPlugin() on the WebView itself, we're going > > >> to need to update our plugins. I did some work on this today, but I > > >> need to know where these changes should live, since I don't think they > > >> belong in master until 4.0.x on Android is released. > > >> > > >> So, What should we do with this? Any ideas? > > >> > > >> Joe > > >> > > > > >
