In particular, I thought the root of the repo wasn't supposed to be a node package, but a bucket for multiple node packages. (ie, should not be a package.json at the root).
We don't vote on commits (though its nice to ask for review for big hairy patches like this one, so thanks for that). -Michal On Mon, Jun 9, 2014 at 3:01 PM, Andrew Grieve <agri...@chromium.org> wrote: > I think all releases require votes. Only difference is that for urgent > releases we can have a shorter vote period. > > Looking at your commit - there's now two package.json files with the same > name. I don't think that's allowed by npm. > > Your goal was to make configparser its own package right? Doesn't it need > its own package.json file to be its own package? > > > On Mon, Jun 9, 2014 at 2:50 PM, Lorin Beer <lorin.b...@gmail.com> wrote: > > > Minor bump to cordova-lib to expose a broken out package. > > > > history: > > > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=shortlog;h=refs/heads/configparser_module > > > > squashed commit to master: > > > > > https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;a=commit;h=3623a84eb391f41c5a32ddc67eea89512c4ba654 > > > > > > This does not change any functionality of the modules, just the way > > they are wired up. It also provides an additional package.json file to > > better expose the cordova-lib submodules. > > > > > > I think that qualifies as a patch, and should not require a release vote. > > > > I will hold off on npm publish for some feedback > > > > - Lorin > > >
