I don't see the point of the change. However, you can re-open the issue and assign it to yourself.
On Fri, Jun 20, 2014 at 6:47 AM, Andrew Grieve <agri...@chromium.org> wrote: > I didn't see any reason against deleting the default icons in there. To be > clear, what we're talking about is: > > CLI's config.xml has an icon: > Yes: Delete template icons then copy in > No: Leave template icons > > Right now what happens is: > Yes: Leave template icons and copy in app icons > No: Leave template icons > > It's a subtle change, but a good one I think. > > > > > > On Thu, Jun 19, 2014 at 10:03 PM, Joe Bowser <bows...@gmail.com> wrote: > >> On Thu, Jun 19, 2014 at 6:01 PM, Andrew Grieve <agri...@chromium.org> >> wrote: >> > I don't think it should resize it, but I do agree we should delete the >> > template ones if any are present. Right now you aren't sure if the <icon> >> > tag even did anything if you fail to replace the right size. >> >> The icon tag is ignored entirely if you're not using the CLI, and it's >> only a CLI thing. The problem I have with this right now is that it >> doesn't provide a good solution to this problem, since as you stated >> earlier, you won't get through App Store review on iOS, and Android >> requires numerous icons when you submit your app anyway. This stupid >> anti-feature is what's preventing the platforms from being treated as >> build artifacts. >> >> > Android and >> > iOS both do a pretty good job at resizing at runtime if only one large >> icon >> > is present (although you won't get through app-store review). >> > >> >> I disagree about Android doing a good job. We just don't notice it >> because we happen to have stupidly high quality template icons and we >> mostly test on hdpi and xhdpi devices. I'm sure if I ran this on an >> mdpi or ldpi device, the icon would be all distorted. >> >> > >> > >> > >> > On Thu, Jun 19, 2014 at 5:17 PM, Joe Bowser <bows...@gmail.com> wrote: >> > >> >> So, it resizes the icon? If not, then the point is still valid. >> >> On Jun 19, 2014 2:11 PM, "Darryl Pogue" <dvpdin...@gmail.com> wrote: >> >> >> >> > On 19 June 2014 13:52, Joe Bowser <bows...@gmail.com> wrote: >> >> > > > It's really not neccessary to have 5 not similar, but exactly same >> >> icon >> >> > > > files, when we can have only 1 icon file. >> >> > > >> >> > > People should be changing their icons anyway, and I don't believe we >> >> > > actually landed any support for the icon element in config.xml. >> >> > >> >> > This support landed in cordova-cli 3.5.0. >> >> > >> >> >>
