Github user mwbrooks commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47569377
Generally, our philosophy for the Hello World app is to avoid over
complicating the code. This is why we use the `app` object instead of a self
executing anonymous function, which would require a certain level of JavaScript
knowledge.
The pull request looks fine to me. My only suggestion would be to leave a
comment explaining that initialization must happen after `cordova.js`:
// initialize the app after the cordova.js script so that deviceready
is registered.
app.initialize();
It would be nice to have an addition Mozillian verify that the change
solves [CB-6949](https://issues.apache.org/jira/browse/CB-6949), before we
merge the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
