Thx Axel. Reviewed, looks good to me. Added a few notes to github. -Sergey -----Original Message----- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Monday, July 14, 2014 3:33 PM To: dev Subject: Re: recent tools update, Splash screen support
I closed my former PR #219, deleted my fork of cordova-docs, reforked, updated images.md, pushed and created another PR: https://github.com/apache/cordova-docs/pull/220 Which now only has one changed file. Axel 2014-07-14 1:30 GMT+02:00 Ray Camden <rayca...@adobe.com>: > Thank you - I finally get what the change was now. ;) > > ________________________________________ > From: Axel Nennker <ignisvul...@gmail.com> > Sent: Sunday, July 13, 2014 11:17 AM > To: dev > Subject: Re: recent tools update, Splash screen support > > > https://github.com/AxelNennker/cordova-docs/commit/a7b2f371c3d051a5a9d > 4818f3f9c9cb0eb5c57be > > Axel > > Sorry about the ton of changed files. I did a "git fetch upstream" > today and then a merge and push to my repo... > I wish I could delete my fork and start over but github does not allow > this... > > > 2014-07-13 17:56 GMT+02:00 Ray Camden <rayca...@adobe.com>: > > > There are 500+ files changed with this PR - can you point to any > > specific files that would be helpful? > > > > ________________________________________ > > From: Axel Nennker <ignisvul...@gmail.com> > > Sent: Sunday, July 13, 2014 10:50 AM > > To: dev > > Subject: Re: recent tools update, Splash screen support > > > > A pull request is here: > > https://github.com/apache/cordova-docs/pull/219 > > > > -Axel > > > > > > 2014-07-12 15:12 GMT+02:00 Ray Camden <rayca...@adobe.com>: > > > > > Just raising this again - are there docs for this? > > > > > > ________________________________________ > > > From: Ray Camden <rayca...@adobe.com> > > > Sent: Friday, July 11, 2014 5:46 AM > > > To: dev@cordova.apache.org > > > Subject: RE: recent tools update, Splash screen support > > > > > > So.... basically the docs are *not* up to the date for any of this yet? > > > ________________________________________ > > > From: Sergey Grebnov (Akvelon) <v-seg...@microsoft.com> > > > Sent: Friday, July 11, 2014 1:15 AM > > > To: dev@cordova.apache.org > > > Subject: RE: recent tools update, Splash screen support > > > > > > I volunteer to test splash/icons support one more time and update > > > the > > docs > > > where it is required. > > > > > > * The old documentation refers to PG Build. Cordova implementation > > > is based on this idea, but there are some differences, for example > > > we > don't > > > support gap: prefix and platform attribute, platform specific > > > icons > must > > be > > > placed inside corresponding <platform name=''> element > > > * We updated icons related docs as part of Cordova icons support > > > implementation, I will double check that it is still accurate (for > > example > > > I see that it mentions platform attribute which is not supported) > > > * We should update splash screen related docs part (as per our > > > implementation + examples) > > > * Splash screen plugin and splash screen images support are > > > related but different features. Core splash screen support by CLI > > > allows replacing default template images which are showed > > > automatically, where the > plugin > > > works on top of this and allows programmatically show/hide splash > screen > > > (pls correct me if I'm wrong). > > > > > > > > >
