Hmm, yeah, I don't like breaking things, but we need to have a way to make changes to 4.0.x without too much debate as well. We didn't have an email discussion for each symbol that was added to the interface, and it's not feasible to do so going forward (for an interface, any change, add, or remove of a function breaks compiles).
My goal in removing getPlugin() was just to cut down on the amount of copy & paste code between AndroidWebView and *WebView. My latest line of thinking is that CordovaWebView should be a concrete class that contains a CordovaWebViewEngine. If this were the case, I think a getPlugin() method would make even more sense. Don't have time to do any more changes in this week probably though. The only code I'm aware of that uses 4.0.x is AndroidWebView + https://github.com/clelland/cordova-crosswalk-engine. I'm quite happy to make sure these always compile at HEAD when making changes. Indeed I would have had to revert fewer of my own changes if I checked that before commiting. If there are other repos I should be looking at, then please let me know. Next time I'm at it I'll check in a script to do test compiles of everything so as to not break things anymore. On Tue, Jul 15, 2014 at 2:26 PM, Joe Bowser <[email protected]> wrote: > OK, now third-party chrome doesn't work anymore. I can't get the > third-party WebView that we've been working on for months to work. I > really need this to work, and I'm going to have to go off a branch > that's months old because someone decided to undo months of work on a > whim. Honestly, I'm cool with the branch being somewhat fast, but you > do have to realize that you're working with other people on this > branch. Can you please stop doing this? > > On Tue, Jul 15, 2014 at 11:01 AM, Ian Clelland <[email protected]> > wrote: > > Looks like it went missing in efcedab (according to git log -S) > > > > Agreed that it's frustrating. (And I liked getPlugin, too). I'd like for > > the 4.0.x branch to remain pretty fast-moving; I don't want to have to > have > > long discussions on the list before every commit, but breaking the public > > API isn't good. It breaks everyone's workflow, since we all have code > that > > lives outside of the core that relies on it. > > > > > > > > On Tue, Jul 15, 2014 at 1:56 PM, Joe Bowser <[email protected]> wrote: > > > >> I was talking about getPlugin(), not getPluginManager(). We used to > >> have that method, and it's gone, and I'm asking here hoping that I > >> don't have to sift through the 30 commits that were put in the repo to > >> figure out where it went. If there was a good tool to check all 30+ > >> commits that happened, that'd help too, but this is extremely > >> frustrating, since I want to demo something. > >> > >> On Tue, Jul 15, 2014 at 10:48 AM, Andrew Grieve <[email protected]> > >> wrote: > >> > I don't think it's been removed: > >> > > >> > https://github.com/apache/cordova-android/blob/4.0.x/framework/src/org/apache/cordova/CordovaWebView.java#L81 > >> > > >> > https://github.com/apache/cordova-android/blob/4.0.x/framework/src/org/apache/cordova/AndroidWebView.java#L732 > >> > > >> > > >> > On Tue, Jul 15, 2014 at 1:33 PM, Joe Bowser <[email protected]> > wrote: > >> > > >> >> Hey > >> >> > >> >> One of the new API methods that we added to the WebView was removed. > >> >> I'm not sure why it was, since we now have to get a PluginManager to > >> >> get a plugin. Aren't we closing off access to the PluginManager? > >> >> Seriously, this should have been discussed before we commit things. > >> >> > >> >> Joe > >> >> > >> >
