Github user jkeshavarzi commented on a diff in the pull request:

    https://github.com/apache/cordova-blackberry/pull/169#discussion_r15114473
  
    --- Diff: bin/templates/project/cordova/lib/cmdline.js ---
    @@ -30,7 +30,8 @@ command
         .option('-p, --params <params JSON file>', 'Specifies additional 
parameters to pass to downstream tools.')
         .option('--appdesc <filepath>', 'Optionally specifies the path to the 
bar descriptor file (bar-descriptor.xml). For internal use only.')
         .option('-v, --verbose', 'Turn on verbose messages')
    -    .option('-l, --loglevel <loglevel>', 'set the logging level (error, 
warn, verbose)');
    +    .option('-l, --loglevel <loglevel>', 'set the logging level (error, 
warn, verbose)')
    +    .option('--signing <true|false>', 'if signing the app');
    --- End diff --
    
    This really should be just --signing. True/false values is not conventional 
for command-line arguments. If --signing is specified it automatically becomes 
set to true/defined.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to