Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/66#discussion_r15553301
  
    --- Diff: cordova-lib/src/plugman/uninstall.js ---
    @@ -316,6 +316,10 @@ function handleUninstall(actions, platform, plugin_id, 
plugin_et, project_dir, w
             // queue up the plugin so prepare can remove the config changes
             
config_changes.add_uninstalled_plugin_to_prepare_queue(plugins_dir, plugin_id, 
platform, is_top_level);
             // call prepare after a successful uninstall
    -        plugman.prepare(project_dir, platform, plugins_dir, www_dir, 
is_top_level);
    +        if (options.browserify) {
    --- End diff --
    
    We added the browserify checks to install & uninstall because ```cordova 
plugin add/rm``` directly calls ```plugman.raw.install/uninstall```. It skips 
going through ```plugman.js``` and therefore 
https://github.com/surajpindoria/cordova-lib/blob/browserify/cordova-lib/src/plugman/plugman.js#L131
 never runs.
    
    A better fix then adding these multiple checks would be to get ```cordova 
plugin add/rm``` to run ```plugman.js```. We haven't explored this yet though.
    
    Once ```prepare-browserify``` becomes the default way of doing things, we 
can remove the old prepare and remove these checks. 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to