Github user csantanapr commented on the pull request:

    https://github.com/apache/cordova-lib/pull/55#issuecomment-52305148
  
    @purplecabbage That was one of my points, that context.cmdLine is not 
useful as a String.
    Why slide() and not just context.cmdLine = process.argv ? just to get a 
shallow copy?
    
    Not part of this pull request, but I think no where in inside cordova-lib 
the global object "process.argv" should be assume to be use. 
    I think is a responsibility of of who ever is calling cordova-lib which in 
this case is cordova-cli here: 
    https://github.com/apache/cordova-cli/blob/master/bin/cordova#L41
    
        addTs('start');
        var cli = require('../src/cli');
        cli(process.argv);
        addTs('end');
    
    then in  ../src/cli
    should parse and pass down remains/noneparsed of inputArgs down to the 
cordova-lib command.
    
    But for now for this pull request I +1 to do context.proc_argv = 
process.argv.slice()
    
    @sgrebnov you going to merge this pull request into master soon?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to