arrg, I can't type going to sleep now... On Mon, Sep 15, 2014 at 11:36 PM, Carlos Santana <[email protected]> wrote:
> just as FYI: the step to generate srinkwrap is located here: > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#L127 > > > On Mon, Sep 15, 2014 at 11:30 PM, Carlos Santana <[email protected]> > wrote: > >> I was trying myself to generate a npm-shrinkwrap.json and got an error >> associated with the version of browserfy included in cordova-js which is >> included in cordova-lib:-) >> 0 info it worked if it ends with ok >> 1 verbose cli [ 'node', >> 1 verbose cli '/Users/csantana23/.nvm/v0.10.31/bin/npm', >> 1 verbose cli 'shrinkwrap' ] >> 2 info using [email protected] >> 3 info using [email protected] >> 4 error Error: Problems were encountered >> 4 error Please correct and try again. >> 4 error invalid: [email protected] >> /Users/csantana23/Documents/SWG/git/cordova/cordova-cli/node_modules/cordova-lib/node_modules/cordova-js/node_modules/browserify/node_modules/derequire/node_modules/esprima-fb >> 4 erro >> >> It looks we are using a 3 months old version 3.46 >> Latest is 5.11.2 https://www.npmjs.org/package/browserify >> >> If we update cordova-js dependency for browserfy from 3.46 to 5.11.2 the >> npm shrinkwrap command doesn't fail >> >> >> On Mon, Sep 15, 2014 at 11:28 PM, Carlos Santana <[email protected]> >> wrote: >> >>> We should always update shrinkwrap.json before going thru test, that way >>> if there is a dependency down the chain (i.e. ALL the chain) that got >>> updated we can pick up the new version and everybody test the same bits. >>> >>> >>> >>> >>> On Mon, Sep 15, 2014 at 11:16 PM, Marcel Kinard <[email protected]> >>> wrote: >>> >>>> >>>> On Sep 15, 2014, at 10:59 PM, Carlos Santana <[email protected]> >>>> wrote: >>>> >>>> > Marcel apache git [1] neither github git [2] for cordova-cli repo has >>>> > cordova-lib pointing to 0.21.11 >>>> > Both have in package.json "cordova-lib" >>>> > : "0.21.10", >>>> >>>> I created a branch for the tools, to avoid picking up new content other >>>> than the necessary adjustments. Look for the tag. >>>> >>>> https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=shortlog;h=refs/heads/rb_3.6.0-0.2.8 >>>> >>>> > Finally the reason that when doing "npm install -g >>>> [email protected]" is >>>> > not installing [email protected] and is installing the old version >>>> 9.2.10 >>>> > is because of npm-shrinkwrap.json inside cordova-cli >>>> >>>> Ah crap, it's the npm-shrinkwrap.json file. Now I see it. I didn't >>>> update the shrinkwrap file because none of the unspecified dependencies >>>> were updated. But in further reading of the shrinkwrap docs, I now see that >>>> the shrinkwrap trumps package.json, not the other way around. >>>> >>>> (Sound of head banging slowly on the wall repeatedly.) >>> >>> >>> >>> >>> -- >>> Carlos Santana >>> <[email protected]> >>> >> >> >> >> -- >> Carlos Santana >> <[email protected]> >> > > > > -- > Carlos Santana > <[email protected]> > -- Carlos Santana <[email protected]>
