On Tue, Sep 16, 2014 at 5:47 PM, Marcel Kinard <cmarc...@gmail.com> wrote:
> Sorry I'm not following exactly what you mean. Do you mean cordova-lib > instead of cordova-cli? > Probably :P. Whichever has the shrinkwrap > > I also don't expect devDependencies to get installed when I do "npm -g > install cordova@rc". > > cordova-js has the devDependency on connect, and does not have a > shrinkwrap. cordova-lib has a dependency on cordova-js, but does have a > shrinkwrap. When I generate the shrinkwrap in cordova-lib, all of the > devDependencies in cordova-js are appearing in the cordova-lib shrinkwrap. > That seems to be where it starts to go wrong. > > cd cordova-lib > rm -r node_modules > rm npm-shrinkwrap > npm install > npm shrinkwrap > > ...and I see the cordova-js devDependencies in the cordova-lib shrinkwrap. > That's wrong, correct? > > It shouldn't matter if I had done an "npm link cordova-js" inside of > cordova-lib, correct? > This is the key! It *does* matter. shrinkwrap just records what it finds in your node_modules directory, symlinks and all! You always want to do a fresh rm -r & npm install before shrinkwrap to ensure you don't have extraneous modules in there. That said, if you did that and it's still showing up, I don't know why that is :S > > I'm trying to figure out if I'm doing something wrong, or if the > shrinkwrap command is misbehaving. > > On Sep 16, 2014, at 4:07 PM, Andrew Grieve <agri...@chromium.org> wrote: > > > You shouldn't be seeing devDependencies show up in cordova. I'd double > make > > sure that if you: > > > > cd cordova-cli > > rm -r node_modules > > rm npm-shrinkwrap.json > > npm install > > npm shrinkwrap > > > > > > that you end up with an npm-shrinkwrap.json that includes the > devDependency. > > > > > > On Tue, Sep 16, 2014 at 4:01 PM, Marcel Kinard <cmarc...@gmail.com> > wrote: > > > >> FYI, I am getting the following warning when I do "npm install > cordova@rc > >> ": > >> > >> npm WARN engine connect@1.8.5: wanted: {"node":">= 0.4.1 < 0.7.0"} > >> (current: {"node":"0.10.31","npm":"1.4.23"}) > >> > >> This is a devDependency in cordova-js, which I didn't change. If folks > >> want this dependency changed to get rid of the warning, then it will > mean > >> respinning this tools release. > >