Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/125#discussion_r18396839
--- Diff: framework/src/org/apache/cordova/NativeToJsMessageQueue.java ---
@@ -419,53 +419,43 @@ private void initReflection() {
this.pluginResult = pluginResult;
}
- int calculateEncodedLength() {
- if (pluginResult == null) {
- return jsPayloadOrCallbackId.length() + 1;
- }
- int statusLen =
String.valueOf(pluginResult.getStatus()).length();
- int ret = 2 + statusLen + 1 + jsPayloadOrCallbackId.length() +
1;
+ int calculateEncodedLength(PluginResult pluginResult) {
--- End diff --
nit: make this static since pluginResult param shadows this.pluginResult
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
