Thanks Kevin. Forwarding to dev@ mailing list. Seems like a candidate for 4.0.x branch? I think those that want to know about the keyboard just use Ionic's keyboard plugin anyways, since that works with newer Android versions.
On Tue, Nov 4, 2014 at 9:41 PM, Kevin Nuss <kevin.n...@infoproc.com> wrote: > I don’t have an account to add comments, so I’m being lazy and merely > emailing you. > > > > In CB-6154 you suggested the removal of the ”hidekeyboard” and > “showkeyboard” events from Cordova, which are in cordova-android > <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b> > /framework > <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b/framework> > /src > <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b/framework/src> > /org > <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b/framework/src/org> > /apache > <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b/framework/src/org/apache> > /cordova > <https://github.com/apache/cordova-android/tree/c2cafb4b45fcbb307a113828dfc9f723f8a6433b/framework/src/org/apache/cordova>/LinearLayoutSoftKeyboardDetect.java. > > > > > If you need additional reasons to do so, this part of that code > > > > else if (screenHeight == width) > > { > > int tmp_var = screenHeight; > > screenHeight = screenWidth; > > screenWidth = tmp_var; > > LOG.v(TAG, "Orientation Change"); > > } > > > > sometimes erroneously causes a hide or show of the keyboard event though I > am merely making an orientation change. The 48 pixel height of the status > bar on a Samsung 10” tablet prevents the height from equaling the previous > width after an orientation change. > > > > I don’t actually use the events, so I don’t care. But if the events are > not deleted, perhaps someone can make the test a little better to handle > the status bar difference. > > Kevin >
