Maybe we should have it auto grab an older version of the plugin that is supported? Or at least a better error message telling them to try older versions of the plugin with cordova plugin add org.apache.cordova.file@VERSION
On Fri, Nov 14, 2014 at 11:49 AM, Michal Mocny <mmo...@chromium.org> wrote: > I just added this to org.apache.cordova.file's plugin.xml as a test: > > <engines> > <engine name="cordova-ios" version=">=4.0.0" /> > </engines> > > Then tried to install that version locally in a project, and got: > > Installing "org.apache.cordova.file" for ios > Failed to install 'org.apache.cordova.file':CordovaError: Plugin doesn't > support this project's cordova-ios version. cordova-ios: 3.6.3, failed > version requirement: >=4.0.0 > > Would probably prefer to clean up the error a bit, but seems to work well. > > On Fri, Nov 14, 2014 at 2:33 PM, Ian Clelland <iclell...@chromium.org> > wrote: > > > On Fri Nov 14 2014 at 2:24:41 PM Shazron <shaz...@gmail.com> wrote: > > > > > General question to everybody: > > > > > > The patch requires the iOS 8 SDK (i.e. Xcode 6). We require Xcode 6 in > > > cordova-ios 3.7.0 and there was consensus on it. > > > However, the plugin.xml itself does not have an engine tag to specify > > what > > > it supports. > > > > > > Question: > > > Do we have engine tag support in the CLI, where it won't install a > > > plugin if the requirements are not met? > > > > > > > We certainly do, for Android at least -- I've been using it for Crosswalk > > development, and it works (I get caught every time I switch back to > > master, and the crosswalk plugin refuses to install :) ) > > > > > > > > > > If not, we would have to do a #ifdef __IPHONE_8_0 macro in the code. > > > > > > > > > On Fri, Nov 14, 2014 at 11:18 AM, Shazron <shaz...@gmail.com> wrote: > > > > > >> Thanks Julio! > > >> I'll comment on the PR itself. > > >> > > >> Shaz > > >> > > >> On Fri, Nov 14, 2014 at 8:42 AM, Ian Clelland <iclell...@chromium.org > > > > >> wrote: > > >> > > >>> Well, I think what you've just done (pinging the list) is pretty > close > > >>> to the right next step. > > >>> > > >>> You should probably assign the issue back to Shaz with a note > directed > > >>> to him asking him to take a look and merge it in. (I'd merge it, but > I > > >>> haven't been following iOS 8 development closely enough to judge its > > >>> correctness) > > >>> > > >>> And thanks for taking it on! > > >>> > > >>> Ian > > >>> > > >>> > > >>> On Fri Nov 14 2014 at 2:32:14 AM julio cesar sanchez < > > >>> jcesarmob...@gmail.com> wrote: > > >>> > > >>>> CB-7734 (https://issues.apache.org/jira/browse/CB-7734) was > reported > > >>>> and I > > >>>> asked if it could be assigned to me. > > >>>> Shazron assigned to me and I fixed it with this pull request > > >>>> https://github.com/apache/cordova-plugin-dialogs/pull/39 > > >>>> > > >>>> It's been 3 weeks and it hasn't been merged, so I don't know if I > have > > >>>> to > > >>>> do something else, it's the first issue assigned to me. > > >>>> > > >>> > > >> > > > > > >
