Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/115#issuecomment-63848626
Looks good overall. 2 style notes, both are optional, tell me if you prefer
not to change it:
1) Would be great if you could run jscs with the default config in
cordova-lib/.jscs.json, it's not set in stone and you are welcome to contribute
to the discussion of what this configuration should look like. But it really
helps with obvious things like trailing spaces etc. that jshint stopped
checking for in the latest versions.
2) underscore usage as "_" turns out to be a bit problematic in node.js
during debugging because node interactive interpreter uses _ to keep the last
printed result. There seem to be no other dominant conventions, but double
underscore "__" is a popular choice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
