+1, I think we shouldn't change the navigator.notifications interface, but the name of the internal type is unlikely to break anyone. Can do a major version bump on the plugin just in case.
-Michal On Wed, Nov 26, 2014 at 11:07 AM, Brian LeRoux <[email protected]> wrote: > ya this is legacy pain; the source formerly known as phonegap predates > push/local notifications! > > used to be vibrate, flash indicator lights (remember those on > blackberries?) and beep (also lol) > > we named the plugin repo cordova-plugin-dialogue (and moved vibrate out) > b/c that seemed more appropriate for alert, confirm and friends. > > since everything is independently revision-ed in plugins now I say: > refactor with impunity. > > On Wed, Nov 26, 2014 at 7:28 AM, Piotr Zalewa <[email protected]> wrote: > > > Hi > > > > I came across an issue in writing a Notification support in Cordova. > > Dialogs plugin uses Notification for a classy object. I think it should > be > > called Dialog or similar and not take the Notification. I actually think > > the navigator.notifications is wrong name either, that however might > hold a > > bigger impact on users currently using it. > > > > Should we change this? > > -- > > Piotr Zalewa > > Mozilla > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > >
