Well, if we find that the feature never worked, then we could just remove it.
@purplecabbage risingj.com On Tue, Jan 6, 2015 at 4:52 PM, Joe Bowser <[email protected]> wrote: > This is an API change, and this would require a major version change for > both Android and CordovaJS. > > On Tue Jan 06 2015 at 4:50:17 PM Shazron <[email protected]> wrote: > > > Fine with me (iOS has no use of it) > > > > On Mon, Jan 5, 2015 at 12:27 PM, Jason Chase <[email protected]> > wrote: > > > I'm working on CB-8210, to remove the use of javascript eval()s from > > native > > > code in cordova-android. The goal is to pave the way for CSP. > > > > > > One usage was to fire the "onDestroy" event when the app is being > > > destroyed. However, in my testing, I wasn't able to get this event > > firing > > > on the javascript side. Upon investigation, I discovered that while > the > > > onDestroy is defined for all platforms (in channel.js), it is only > > > implemented for android. Further, the code defines it as an internal > > > event, which should not be used in app code (guidance is to use > > > window.onunload instead). I couldn't find any internal code using > > > onDestroy. > > > > > > Given the above, is there any reason to keep the onDestroy event? It > > seems > > > the simplest thing to do is remove the event, rather than spending more > > > effort on getting it to work under CSP. As well, it's defined as an > > > internal event, so I assume that removal would not be considered an API > > > change. > > > > > > I'd welcome any comments for/against removing onDestroy. > > > > > > Thanks, > > > Jason > > > Google Cordova team > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > >
