Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/140#issuecomment-69129747
Merged! However - after a closer look at the unit tests, I highly encourage
you to try and refactor things so that the tests do not mock out private
methods within modules (e.g. like `resolvePath()`). Tests that do that make it
very hard to change the code going forward, as it tests implementation details
rather than function pre/post-conditions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
