On 9 Jan 2015, at 14:13, Treggiari, Leo wrote:
I had asked some questions about save and restore a while back, but
have not been following the progress in detail - so ignore me if you
feel it is appropriate.
One of my biggest questions was why would these commands be an option?
Ironically, the very first implementation did not introduce commands but
rather hooked itself for plugin/platform add/rm and prepare, sort of
like what [1] introduces with config.json preferences. However during
the review it was suggested that these needs to be commands at least for
a while.
[1] https://github.com/apache/cordova-lib/pull/143
What I'm looking for, as soon as possible, is that Cordova 'project'
metadata is stored logically and consistently so that the CLI and
multiple IDEs could simultaneously work on the same project and know
about what each other have done wrt. adding/removing
plugins/platforms/etc.
That is one of my motivations, right now too much depends on plugins and
platforms folders being present.
Does removing experimental advance that goal or does it, as Michal
says, put obstacles in the path of getting there by requiring long
term support of an incomplete and possibly confusing (more options?)
solution?
Removing experimental matters only if we want to keep save and restore
as separate commands. Otherwise, it is a matter of agreeing on a goal.
Leo
-----Original Message-----
From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal
Mocny
Sent: Friday, January 09, 2015 10:35 AM
To: dev
Subject: Re: platforms/plugins save and restore from config.xml
-1 on removing experimental.
I love the concept behind this feature, and I applaud Gorkem for
actually
working on pushing it forward, but I'm still concerned the current
design
is not perfect. Just today we were discussing storing the list of
plugins
into a package.json if plugins move to npm. The current
implementation
still saves all installed plugins including dependencies and not just
what
was explicitly added.
If we add this outside experimental, and document & broadcast it, we
will
have to support it going forward. That will certainly influence
future cli
designs.
-Michal
On Fri, Jan 9, 2015 at 12:08 PM, Gorkem Ercan <gorkem.er...@gmail.com>
wrote:
On 9 Jan 2015, at 10:41, Andrew Grieve wrote:
Questions: Would ever not want to use --save? Why not just always
update
config.xml with what plugins you have?
Eclipse Thym always updates the plugin & platform information to
config.xml, and no one complained about it so far.
Likewise, would you ever not want to have --shrinkwrap? I think you'd
always want the plugin/platform version listed in there.
I do not set the shrinkwrap for plugins usually, because without
shrinkwrap, the latest version is restored. I usually prefer the
latest
with the stable plugins, such as the core plugins.
As a reference, Eclipse Thym does not shrinkwrap by default but has a
preference you can turn on.
With platforms shrinkwrap as default makes sense.
On Fri, Jan 9, 2015 at 1:46 AM, Mefire O. <ommen...@microsoft.com>
wrote:
Also, I have Pull Requests that implements the --save flag as
mentioned
earlier :
- https://github.com/apache/cordova-cli/pull/203
- https://github.com/apache/cordova-lib/pull/144
Thanks,
Mefire
-----Original Message-----
From: Mefire O. [mailto:ommen...@microsoft.com]
Sent: Thursday, January 8, 2015 10:27 PM
To: Cordova Dev
Subject: RE: platforms/plugins save and restore from config.xml
+1 on removing the --experimental flag after fixing the 'variables
not
being saved' bug.
Thanks,
Mefire
-----Original Message-----
From: Josh Soref [mailto:jso...@blackberry.com]
Sent: Thursday, January 8, 2015 8:49 PM
To: Cordova Dev
Subject: Re: platforms/plugins save and restore from config.xml
Until adding plugins saves the variables provided, we really
shouldn't /
can't make this non experimental.
Sent from my BlackBerry 10 smartphone.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
