Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22899820
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
this change looks like you replaced a *nix symlink w/ a file.
the change shouldn't be done in the same commit as adding support for
`update`.
and you should probably do something to ensure that someone doesn't later
undo this when working from *nix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
