Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25725351
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
rc('plugman', {
cache: plugmanCacheDir,
- registry: 'http://registry.cordova.io',
+ registry: registryURL,
logstream: fs.createWriteStream(path.resolve(plugmanConfigDir,
'plugman.log')),
userconfig: path.resolve(plugmanConfigDir, 'config'),
'cache-min': oneDay
});
+
+ // if npm is true, use npm registry.
+ // ~/.plugman/config overides the above config if it exists.
--- End diff --
I think it's the same that Tim points out. Normally users don't have a
registry override in their plugman/config, but when they do, we should use it.
Probably the logic should actually be:
if (custom registry) {
use it only
} else {
try CPR and fallback to NPM
}
It's pretty fringe though, so maybe just add a TODO to support custom
registries again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
