looks good. Should you un-pin the version of dep-mapper though? On Wed, Mar 4, 2015 at 8:03 PM, Steven Gill <[email protected]> wrote:
> I have updated the PR based on feedback. Take a look. I'd like to merge it > into master if everyone feels good about it. > > https://github.com/apache/cordova-lib/pull/175/files > > On Tue, Mar 3, 2015 at 11:59 AM, Steven Gill <[email protected]> > wrote: > > > Thanks for all of the feedback so far! I will spend some time this > > afternoon making some changes. > > > > On Tue, Mar 3, 2015 at 9:13 AM, Steven Gill <[email protected]> > > wrote: > > > >> Darryl, > >> > >> +1 to what Michal said. We are still figuring out details for phase 2. > >> Support for package.json and installation from node_modules are two > things > >> I'd love to see supported. > >> On Mar 3, 2015 8:54 AM, "Michal Mocny" <[email protected]> wrote: > >> > >>> Darryl, > >>> > >>> I believe that cordova-cli will continue to use `cordova plugin add` > and > >>> not use `node_modules` at all for phase 1 rollout. It will use the > `npm` > >>> library to fetch into the existing plugins/ folder. There will be no > >>> user > >>> visible change to project structure, though the plugins are being > renamed > >>> as part of the transition. > >>> > >>> -Michal > >>> > >>> On Tue, Mar 3, 2015 at 10:31 AM, Darryl Pogue <[email protected]> > >>> wrote: > >>> > >>> > Less a comment on the code and more of a question about the NPM > >>> > transition from an end-user pespective: > >>> > > >>> > Is Cordova going to automatically discover and use plugins that are > >>> > found in the node_modules folder (from package.json), or will it > still > >>> > keep its own plugins folder and require they be installed using > >>> > `cordova plugin add <name>`? > >>> > > >>> > On 3 March 2015 at 06:40, Andrew Grieve <[email protected]> > wrote: > >>> > > > >>> > > Good stuff. Added some style comments, but logic lgtm! > >>> > > > >>> > > On Tue, Mar 3, 2015 at 3:55 AM, Steven Gill < > [email protected]> > >>> > wrote: > >>> > > > >>> > > > Also, Issue: https://issues.apache.org/jira/browse/CB-8551 > >>> > > > > >>> > > > On Tue, Mar 3, 2015 at 12:54 AM, Steven Gill < > >>> [email protected]> > >>> > > > wrote: > >>> > > > > >>> > > > > PR: https://github.com/apache/cordova-lib/pull/175/files > >>> > > > > > >>> > > > > Please review, leave feedback and ask questions! > >>> > > > > > >>> > > > > >>> > > >>> > --------------------------------------------------------------------- > >>> > To unsubscribe, e-mail: [email protected] > >>> > For additional commands, e-mail: [email protected] > >>> > > >>> > > >>> > >> > > >
