Github user omefire commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/182#discussion_r26094901
  
    --- Diff: cordova-lib/src/configparser/ConfigParser.js ---
    @@ -279,113 +269,108 @@ ConfigParser.prototype = {
     
             return scriptElements.filter(filterScriptByHookType);
         },
    -
    +   /**
    +    * Returns a list of plugin (IDs)
    +    * @return {string[]} Array of plugin IDs
    +    */
    +    getPluginIdList: function () {
    +        var plugins = this.doc.findall('plugin');
    +        var result = plugins.map(function(plugin){
    +            return plugin.attrib.name;
    +        });
    +        var features = this.doc.findall('feature');
    --- End diff --
    
    A comment here to let future code readers would be great !
    I can foresee people scratching their head as to if/why we are supporting 
both syntax.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to