[GitHub] cordova-plugin-inappbrowser pull request: Make toolbar more iOS7 &...

Sat, 14 Mar 2015 06:36:33 -0700 

Github user cjpearson commented on the pull request:

    
https://github.com/apache/cordova-plugin-inappbrowser/pull/92#issuecomment-80476954
  
    I'm seeing some extra grey area when hiding the location bar and showing 
the toolbar on top.
    `window.open('http://google.com', '_blank', 
'location=no,toolbarposition=top')`
    
    
    ![ios simulator screen shot mar 14 2015 9 29 11 
am](https://cloud.githubusercontent.com/assets/2095133/6651826/a1921b06-ca2c-11e4-816a-e0ae6b02f30c.png)
    
    Changing TOOLBAR_HEIGHT to TOOLBAR_MARGIN_HEIGHT on line 649 fixes this, 
but may open some other issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to