Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r26704092
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +442,29 @@ function parseOpts(options, resolvedTarget) {
console.warn('Build option \'' + options[i] + '\' not
recognized (ignoring).');
}
}
+ if (packageArgs.keystore && packageArgs.alias) {
+ var keystore = path.relative(ROOT,
path.resolve(packageArgs.keystore));
+ ret.packageInfo = new PackageInfo(keystore, packageArgs.alias,
packageArgs.keystorePassword,
+ packageArgs.password, packageArgs.keystoreType);
+ } else if (fs.existsSync(path.join(CORDOVAROOT, BUILD_CONFIG_FILE))) {
--- End diff --
We've made it this far without platforms having CLI-specific code, so I
think we should not check at this file location. Instead, we could have
"cordova prepare" create -signing.properties files, or have "cordova run" pass
along all the signing args as CLI arguments. Could even pass it along as a
single argument that points to the JSON file, but I don't think we should look
for it here directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
