GitHub user mmrko opened a pull request:
https://github.com/apache/cordova-lib/pull/188
Fall back to platform's default orientation only if using the 'default'
global orientation
In regards to the changes introduced in #128 a small change would probably
be in place.
Currently, if no orientation is specified in `config.xml` Cordova will
delete the orientation entry from the manifest/config of a given platform
letting the platform fall back to its default behaviour. That is, the behaviour
of undefined orientation is currently identical to the `default` global
orientation. In retrospect, it would probably lead to less confusion if a
platform's orientation setting would be left untouched if no orientation is
specified in `config.xml`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmrko/cordova-lib pref-orientation-default
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit de934984a93cd2488daf5e39f32194691b9fc020
Author: Marko Raatikka <[email protected]>
Date: 2015-03-20T11:53:57Z
Fall back to platform's default orientation only if using 'default'
orientation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
