Looks like this breaks on cordova-android 3.7.1 (currently latest released)

cordova-app-hello-world requires the whitelist plugin
whitelist plugin depends on cordova-android 4.0 via the engine tag
<engine name="cordova-android" version=">=4.0.0-dev" />
The resulting error message is
Plugin doesn't support this project's cordova-android version.
cordova-android: 3.7.1, failed version requirement: >=4.0.0-dev

Simply removing the <engine> tag results in compile errors. (change
in CustomConfigXmlParser.parse() signature).

Any ideas on how to solve this would be appreciated. Ideas we came up with
in a quick discussion:

1. Add "ignore" attribute to the <engine> tag that would result in plugin
being silently ignored for incompatible engines rather than going down in
flames.
2. Add either <version> child or "version" attribute to the <platform> tag
in plugin.xml


On Fri, Mar 27, 2015 at 4:31 PM, Andrew Grieve <[email protected]> wrote:

> +1
>
> * Tested that both plugins compile on Android
> * Tested that the non-legacy plugin does what its supposed to on Android
>
> On Thu, Mar 26, 2015 at 7:46 PM, Steven Gill <[email protected]>
> wrote:
>
> > Please review and vote on the releases of cordova-plugin-whitelist and
> > cordova-plugin-legacy-whitelist plugins.
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-8739
> >
> > The plugins have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8739/
> >
> > The packages were published from their corresponding git tags:
> > cordova-plugin-whitelist: 1.0.0
> > (38f5a9fa2c)cordova-plugin-legacy-whitelist: 1.0.0 (1ce26eba64)
> >
> > Upon a successful vote I will upload the archives to dist/ and upload
> > them to npm.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and
> > subdependencies have Apache-compatible licenses
> >
>

Reply via email to