Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446054
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
console.warn('Build option \'' + options[i] + '\' not
recognized (ignoring).');
}
}
+ if (packageArgs.keystore && packageArgs.alias) {
+ var keystore = path.relative(ROOT,
path.resolve(packageArgs.keystore));
+ ret.packageInfo = new PackageInfo(keystore, packageArgs.alias,
packageArgs.keystorePassword,
+ packageArgs.password, packageArgs.keystoreType);
+ } else if (fs.existsSync(buildConfig)) {
+ console.log('Reading build config file: '+ buildConfig);
+ var config = JSON.parse(fs.readFileSync(buildConfig, 'utf8'));
+ if (config.android && config.android[ret.buildType]) {
+ var androidInfo = config.android[ret.buildType];
+ if (androidInfo.keystore && androidInfo.alias) {
+ var configDir = path.dirname(buildConfig);
+ var keystorePath = path.relative(ROOT,
path.join(configDir, androidInfo.keystore));
+ ret.packageInfo = new PackageInfo(keystorePath,
androidInfo.alias,
+ androidInfo.keystorePassword, androidInfo.password,
androidInfo.storeType);
--- End diff --
A bit inconsistent to have "keystorePassword" and "storeType" (should be
storePassword, or keystoreType). I think the [gradle
terms](http://stackoverflow.com/questions/18328730/how-to-create-a-release-signed-apk-file-using-gradle)
for these make sense, so might as well use them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
