Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/173#discussion_r28009343
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -95,6 +95,9 @@ Licensed to the Apache Software Foundation (ASF) under one
protected ArrayList<PluginEntry> pluginEntries;
protected CordovaInterfaceImpl cordovaInterface;
+ //flag for case when appView is null during onStart
+ private boolean shouldHandleStartOnAppViewInit = false;
--- End diff --
The webview (and thus plugins) are generally created from onCreate(), which
means they will be initialized before the first call to onStart. If you're unit
tests passes without this flag (and without the one in CordovaWebViewImpl),
then I think you should remove them. It's not obvious (to me anyways) that this
behaviour would even be the desired behaviour. If there's a reason it needs to
be this way, then let me know! But if so, then we should upated onResume as
well so that we're consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
