Re: Cordova 5.0.0 "duplicate cordova" check breaks Ripple

[Jesse]

I think ripple will need to change, I'll have a look and see if there is a more 
elegant way to implement honeypot. 



> On Apr 30, 2015, at 7:06 PM, Tim Barham <tim.bar...@microsoft.com> wrote:
> 
> ​Hey everyone - a bug was filed today against Ripple that it is broken with 
> Cordova 5.0.0. The issue is that Ripple triggers the new "duplicate cordova" 
> check:
> 
> Â Â Â  cordova-js/src/cordova.js line 22: 
> Â Â Â  if ("cordova" in window) { throw new Error("cordova already defined"); 
> };
> 
> Ripple patches cordova by defining a setter for window.cordova to intercept 
> it being created. This is sufficient to make ("cordova" in window) return 
> true.
> I don't see a way to readily resolve this issue in Ripple. We can fix it in 
> Cordova by changing the test to:
> 
>   if (window.cordova) ...
> 
> Couple of questions:
> 1. Any reason not to make this change?
> 2. To get this fix out will require re-releasing all platforms, correct? And 
> I presume a tools release to update the pinned platforms? Is this sufficient 
> reason to trigger such a release?
> 
> Thanks!
> 
> Tim
> ТÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÒÐÐ¥FòVç7V'67&–&RÂRÖÖ–âFWb×Vç7V'67&–&T6÷&F÷fæ6†Ræ÷&pФf÷"FF—F–öæÂ6öÖÖæG2ÂRÖÖ–âFWbÖ†VÇ6÷&F÷fæ6†Ræ÷&pÐ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org