Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-mobile-spec/pull/128#discussion_r29981882
--- Diff: createmobilespec/createmobilespec.js ---
@@ -56,7 +56,8 @@ function popd(dir) {
}
function pluginAdd(pluginName, searchPath, extraFlags) {
- var command = cli + ' plugin add ' + pluginName + ' --searchpath ' +
searchPath;
+ var sp = SEARCH_PATHS.hasOwnProperty(pluginName) ?
SEARCH_PATHS[pluginName] : searchPath;
--- End diff --
It's clearer to put this logic outside of the function, on [line 568]
(https://github.com/apache/cordova-mobile-spec/pull/128/files#diff-ad19d116ad56f7b3ae8ee9fdc8733f69R568).
That way pluginAdd is only concerned with adding a plugin from a given path,
not with extra logic regarding the path.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
